Provide Plugin.AddUniqueError with dedupe behavior
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to Plugin.AddError which does not provide deduplication of errors before growing the collection, the Plugin.AddUniqueError method *does* provide deduplication. The dedupe behavior is provided by case-insensitive comparison of the error string for the provided error against existing errors already in the collection. refs GH-214
atc0005
deleted the
i214-provide-method-to-grow-errors-collection-with-dedupe-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to
Plugin.AddErrorwhich does not provide deduplication of errors before growing the collection, thePlugin.AddUniqueErrormethod does provide deduplication.The dedupe behavior is provided by case-insensitive comparison of the error string for the provided error against existing errors already in the collection.
fixes GH-214